Hi Andrei,
> Use HCI error reasons instead of magic numbers.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> ---
> include/net/bluetooth/hci.h | 8 ++++++++
> include/net/bluetooth/hci_core.h | 2 +-
> net/bluetooth/hci_conn.c | 2 +-
> net/bluetooth/hci_event.c | 4 ++--
> net/bluetooth/l2cap_core.c | 8 ++++----
> 5 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index c5fcd13..b9b0ca9 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -288,6 +288,10 @@ struct hci_cp_create_conn {
> __u8 role_switch;
> } __packed;
>
> +#define HCI_REASON_DISC_AUTH_FAILURE 0x05
> +#define HCI_REASON_DISC_REMOTE_USER 0x13
> +#define HCI_REASON_DISC_LOCAL_HOST 0x16
> +
actually these are HCI error/status codes that are well defined and go
beyond just disconnect reason. Using REASON_DISC seems to be wrong here.
Can you come up with better naming?
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
