Hi Peter, On Wed, Oct 26, 2011 at 10:44:51AM -0700, Peter Krystad wrote: > Hi Andrei, > > > Patches looks OK (taking that typedef is a standard way in bluez). > > > > The only note: I think that we need to differentiate AMP and A2MP. When we > > are dealing with A2MP protocol we could name structures / functions as > > a2mp_* > > I tried to follow the convention of the spec, which uses A2MP only when > referring to the protocol as a whole and when referring to the feature mask > and the fixed channel. It uses AMP or 'AMP Protocol' in all other places, > including individual protocol elements. > > Consider this, and if you still think it should be a2mp_ I'll do it. I think we can do a little brainstorming here :-) My idea is to use name A2MP when we are talking about "AMP Manager Protocol" and use AMP when we are dealing with "Alternate MAC PHY" controller. BTW: in your kernel repository you use correct names https://www.codeaurora.org/gitweb/quic/la/?p=kernel/msm.git;a=blob;f=include/net/bluetooth/amp.h;h=4b080791ffc74ad17fd504583f7949cd4df1fa82;hb=refs/heads/msm-3.0 ... /* A2MP command codes */ #define A2MP_COMMAND_REJ 0x01 #define A2MP_DISCOVER_REQ 0x02 #define A2MP_DISCOVER_RSP 0x03 ... in your patch "[PATCH bluez 2/2] Add A2MP definitions" you use AMP instead of A2MP. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
