RE: [PATCH v2 1/2] Simplify eir_parse function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johan,Frederic,

> 
> 
> If there are multiple name tags in the EIR data you would leak here all
> of them except the last one (devices shouldn't have this but you can't
> control all sorts of crazy things people do). To keep the behavior as
> the existing code, free eir->name when encountering multiple tags and
> just keep the last one.
> 

The spec is very unspecific here (BT 4.0, Vol.3 Part C, section 11.1). Other than the Flags AD Data type which explicitly prohibits sending more than one, and the service solicitation AD type which implicitly limits it to one instance ("One of the Service Solicitation AD types may be sent to invite...."), all other AD Types are not limited in any way. A broadcaster/peripheral may send multiple instance of AD types. I'm not sure it is very clear how to handle two service AD types with different services, or handling two Full name AD types with different data. Maybe we should take a decision here to use the latest values advertised for those inconclusive AD Data types ?

Chen Ganir.

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux