Re: [PATCH 1/2] Fix MediaPlayer documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Wed, Oct 19, 2011 at 7:31 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Wed, Oct 19, 2011 at 2:24 AM, Lucas De Marchi
> <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> ---
>>  doc/media-api.txt |   10 ++--------
>>  1 files changed, 2 insertions(+), 8 deletions(-)
>>
>> diff --git a/doc/media-api.txt b/doc/media-api.txt
>> index b8dcdbd..e061f38 100644
>> --- a/doc/media-api.txt
>> +++ b/doc/media-api.txt
>> @@ -180,12 +180,6 @@ Signals            PropertyChanged(string setting, variant value)
>>
>>                                        Track duration in milliseconds
>>
>> -               StatusChanged(string status, uint32 position)
>> -
>> -                       Possible status: "playing", "stopped", "paused",
>> -                                       "forward-seek", "reverse-seek" or
>> -                                       "error"
>> -
>
> Nice catch.
>
>>  Properties     string Equalizer [readwrite]
>>
>>                        Possible values: "off" or "on"
>> @@ -203,13 +197,13 @@ Properties        string Equalizer [readwrite]
>>
>>                        Possible values: "off", "alltracks" or "group"
>>
>> -               string Status [readonly]
>> +               string Status [readwrite]
>>
>>                        Possible status: "playing", "stopped", "paused",
>>                                        "forward-seek", "reverse-seek" or
>>                                        "error"
>>
>> -               uint32 Position [readonly]
>> +               uint32 Position [readwrite]
>
> Im not sure about making those properties readwrite, iirc there is no
> way to set those values directly via AVRCP commands instead there is
> the key presses to control the playback, so for now I would leave them
> as readonly so the player don't have to handle this in
> org.bluez.MediaPlayer.SetProperty.

/me confused.... I'm just documenting what's implemented right now.
Otherwise, if we don't have the StatusChanged method above, how does
user set position and status?

Looking at the impl. of mpris-player, e.g.:

parse_property() {
...
			emit_property_changed(sys, path,
					"org.bluez.MediaPlayer", "Status",
					DBUS_TYPE_STRING, &value);
...
			emit_property_changed(sys, path,
					"org.bluez.MediaPlayer", "Position",
					DBUS_TYPE_UINT32, &msec);
}

regards,
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux