Hi Luiz,
On Tue, Oct 11, 2011 at 6:47 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Mon, Oct 10, 2011 at 3:37 PM, Lucas De Marchi
> <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> Since "138f831 AVRCP: return empty string instead of rejecting" we
>> return empty strings for all the attributes when there isn't any value
>> set.
>> ---
>> audio/avrcp.c | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/audio/avrcp.c b/audio/avrcp.c
>> index c36af5d..058fa83 100644
>> --- a/audio/avrcp.c
>> +++ b/audio/avrcp.c
>> @@ -600,10 +600,6 @@ static uint8_t avrcp_handle_get_element_attributes(struct avrcp_player *player,
>> nattr = pdu->params[8];
>>
>> if (!nattr) {
>> - /*
>> - * Return all available information, at least
>> - * title must be returned.
>> - */
>> for (i = 1; i < AVRCP_MEDIA_ATTRIBUTE_LAST; i++) {
>> size = player_get_media_attribute(player, i,
>> &pdu->params[pos],
>> --
>> 1.7.7
>
> Ack.
Following your suggestion for patch 7/7, this comment must remain
since we will need to treat title as a special case in
player_get_media_attribute().
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
