Hi Santiago,
On Thu, Sep 29, 2011, Santiago Carot-Nemesio wrote:
> +struct thermometer {
> + DBusConnection *conn; /* The connection to the bus */
> + struct btd_device *dev; /* Device reference */
> + struct att_range *svc_range; /* Thermometer range */
> +};
This struct has inconsistent indentation between the variable types and
their names. The first two ones use spaces whereas the third one uses a
tab.
> +static void destroy_thermometer(gpointer user_data)
> +{
> + struct thermometer *t = user_data;
> +
> + dbus_connection_unref(t->conn);
> + btd_device_unref(t->dev);
> + g_free(t->svc_range);
> + g_free(t);
Incorrect indentation for the last line (just spaces).
> + }
> +
> + thermometers = g_slist_prepend(thermometers, t);
> return 0;
Minor nitpick: add an empty line before the return statement.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
