Re: [PATCH BlueZ] Fix using the attribute struct for encoding ATT pdus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On 19:08 Thu 06 Oct, Johan Hedberg wrote:
> Hi Vinicius,
> 
> On Thu, Oct 06, 2011, Vinicius Costa Gomes wrote:
> > The enconding and decoding of ATT pdus should be kept as much
> > free of dependences from other parts of the code as possible, so
> > it can be used in many contexts.
> > 
> > In this case, for encoding and decoding notifications and indications
> > we did have to pass an instance of an attribute instead of direct
> > values.
> > ---
> >  attrib/att.c |   45 +++++++++++++++++++++++++--------------------
> >  attrib/att.h |    9 ++++++---
> >  2 files changed, 31 insertions(+), 23 deletions(-)
> 
> Did you forget to include the changes to the places where this API is
> used? The source tree should remain compilable between each individual
> commit (to maintain e.g. bisectability) and that's not happening with
> your patch.

I messed up with my last rebase, sorry about that. Fixed patch coming
soon.

> 
> Johan

Cheers,
-- 
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux