Hi,
On Mon, Oct 3, 2011 at 11:57 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> This prevent to disconnect AVRCP when doing e.g. Audio.Disconnect
> ---
> audio/avctp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avctp.c b/audio/avctp.c
> index e9b8e40..b8cb36e 100644
> --- a/audio/avctp.c
> +++ b/audio/avctp.c
> @@ -1021,7 +1021,7 @@ struct avctp *avctp_connect(const bdaddr_t *src, const bdaddr_t *dst)
>
> void avctp_disconnect(struct avctp *session)
> {
> - if (session->io)
> + if (!session->io)
At least in oFono we have a coding style rule to always compare
pointers to NULL. I even have an old patch in bluez/gdbus for this:
6e66423fe87441e3e61e5a325fde1515efa63ac5
Luiz, Johan, Marcel: wouldn't it be better if BlueZ used this rule,
too? (and put the rules somewhere like oFono does?)
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
