Hi Luiz, On Thu, Sep 29, 2011 at 2:07 PM, Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx> wrote: > We sure want to send notifications only when section is not NULL. > Otherwise we either crash or do not send the expected notification. > --- > audio/avrcp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/audio/avrcp.c b/audio/avrcp.c > index ac9a107..e5b51db 100644 > --- a/audio/avrcp.c > +++ b/audio/avrcp.c > @@ -549,7 +549,7 @@ static int avrcp_send_event(struct media_player *mp, uint8_t id, void *data) > uint16_t size; > int err; > > - if (mp->session) > + if (mp->session == NULL) > return -ENOTCONN; This fixes the issue with recent code move, but thinking about it see the following scenario: 1) CT connects to TG and registers itself for events 2) CT disconnects 3) CT connects again, but does not register for receiving track-change notification 4) Track changes and we send the track-change notification It seems like (4) is wrong and what we really need to do is to unregister the events when we are disconnected. What do you think? Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
