Hi Yegor, On Mon, Sep 05, 2011, Yegor Yefremov wrote: > override speed setting if firmware script issues serial settings command, > otherwise the value given in the firmware script will be overridden. > > Example: > > hciattach /dev/ttyO1 texas 115200 > > will fail, because /dev/ttyO1 will be opened with 115200 b/s, then > the firmware script will set the buadrate to 3000000 b/s, after UART init > hciattach.c will set the baudrate to 115200, so communication is broken. > > The only correct way is to set both speeds: > > hciattach -s 115200 /dev/ttyO1 texas 3000000 > > With this patch only initial speed must be specified. The former semantic > will be preserved in case the firmware script doesn't provide serial > settings action. > > Tested with wl1271 and firmware TIInit_7.2.31.bts > > Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> > --- > tools/hciattach.c | 2 +- > tools/hciattach.h | 2 +- > tools/hciattach_ti.c | 19 +++++++++++-------- > 3 files changed, 13 insertions(+), 10 deletions(-) Applied after fixing the commit message (we don't use Signed-off-by). Thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
