Re: [PATCH] Bluetooth: Fix possible NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Waldemar,

> >>   	conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK,&ev->bdaddr);
> >> -	if (conn&&  conn->state == BT_CONNECTED) {
> >> -		hci_conn_hold(conn);
> >> -		conn->disc_timeout = HCI_PAIRING_TIMEOUT;
> >> -		hci_conn_put(conn);
> >> -	}
> >> +	if (conn) {
> >
> > what is from with this:
> >
> > 	if (!conn)
> > 		goto unlock;
> >
> 
> Well, the file is mixed in style, thus I chose the style as for nearby 
> functions. Anyway, if this form is preferable let me know and will update.

for simple code pieces, I don't really mind, but this function is
getting more and more complicated. So less indentation is preferred.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux