Re: [PATCH BlueZ 2/5] AVRCP: rename avrcp_header to avc_header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

On Mon, Sep 12, 2011 at 4:10 PM, Lucas De Marchi
<lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> -       int sk;
>> +                                                       AVC_HEADER_LENGTH];
>> +       int sk = g_io_channel_unix_get_fd(control->io);
>
> You are re-introducing a bug here. Please see "dec26ee Fix fd usage
> when not connected"

Must have reintroduced it when I was rebasing it, gonna fix it.

>
>> +       struct avrcp_spec_avc_pdu *pdu = (void *) avc + AVC_HEADER_LENGTH;
>
> We might want to change this to:
>
> struct avrcp_spec_avc_pdu *pdu = (avrcp_spec_avc_pdu *)(avc +
> AVC_HEADER_LENGTH);
>
> This way we kill some warnings on ARM: arithmetic with void pointer

Don't remember seeing any problem with it, but anyway it is not
something Im introducing.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux