2011/9/6 Siarhei Siamashka <siarhei.siamashka@xxxxxxxxx>: > On Tue, Sep 6, 2011 at 10:40 AM, Luiz Augusto von Dentz > <luiz.dentz@xxxxxxxxx> wrote: >> From: Maarten Bosmans <mkbosmans@xxxxxxxxx> >> >> --- >> sbc/sbc_primitives_armv6.c | 4 ++-- >> sbc/sbc_primitives_iwmmxt.c | 4 ++-- >> sbc/sbc_primitives_mmx.c | 14 +++++++------- >> sbc/sbc_primitives_neon.c | 28 ++++++++++++++-------------- >> 4 files changed, 25 insertions(+), 25 deletions(-) > > Not that I'm opposing this change, but having some rationale and > explanations in the commit message would be nice. First: consistency. __asm__ was already used elsewhere in the files, so using that throughout is cleaner. Second: both asm and __asm__ are GCC-specific extensions, not defined in the C standard. When compiling with --std=gnu99 both are recognized, but when using --std=c99 only __asm__ is recognized to make it perfectly clear that you're not using some standard C99 construct, but a GCC-extension. Maarten Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
