Re: [PATCH] avrcp: do not get fd when not connected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lucas,

On Thu, Aug 25, 2011 at 8:33 PM, Lucas De Marchi
<lucas.demarchi@xxxxxxxxxxxxxx> wrote:
> ---
>  audio/control.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/audio/control.c b/audio/control.c
> index 882c9fb..9990b06 100644
> --- a/audio/control.c
> +++ b/audio/control.c
> @@ -727,7 +727,7 @@ static int avctp_send_event(struct control *control, uint8_t id, void *data)
>        struct avrcp_header *avrcp = (void *) &buf[AVCTP_HEADER_LENGTH];
>        struct avrcp_spec_avc_pdu *pdu = (void *) &buf[AVCTP_HEADER_LENGTH +
>                                                        AVRCP_HEADER_LENGTH];
> -       int sk = g_io_channel_unix_get_fd(control->io);
> +       int sk;
>        uint16_t size;
>
>        if (control->state != AVCTP_STATE_CONNECTED)
> @@ -783,6 +783,8 @@ static int avctp_send_event(struct control *control, uint8_t id, void *data)
>        size += AVCTP_HEADER_LENGTH + AVRCP_HEADER_LENGTH +
>                                        AVRCP_SPECAVCPDU_HEADER_LENGTH;
>
> +       sk = g_io_channel_unix_get_fd(control->io);
> +
>        if (write(sk, buf, size) < 0)
>                return -errno;
>
> --
> 1.7.6

This looks like a bug, in such case we usually use 'fix' in the
description. But the patch looks good.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux