Re: [PATCH 2/3] AVRCP: Metadata item #7 should return TrackDuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan

-----Original Message----- From: Johan Hedberg
Sent: Wednesday, August 24, 2011 3:30 AM
To: David Stockwell
Cc: linux-bluetooth@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/3] AVRCP: Metadata item #7 should return TrackDuration

Hi David,

On Tue, Aug 23, 2011, David Stockwell wrote:
@@ -194,7 +194,8 @@ enum media_info_id {
 MEDIA_INFO_TRACK = 4,
 MEDIA_INFO_N_TRACKS = 5,
 MEDIA_INFO_GENRE = 6,
- MEDIA_INFO_CURRENT_POSITION = 7,
+ MEDIA_INFO_PLAYING_TIME = 7,
+ MEDIA_INFO_LAST = MEDIA_INFO_PLAYING_TIME,
 };

Actually that's not quite what I meant. The idea was this:

MEDIA_INFO_PLAYING_TIME = 7,
MEDIA_INFO_LAST,

That way you can just keep adding new entries above MEDIA_INFO_LAST and
its value will always be the last "real" value + 1 (which also means
that the comparison in the for-loop changes from <= to <).

+++++ Thanks.  As you can tell, C is not my most frequently used language...
I'll take care of it and resubmit.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux