Hi Luiz,
On Thu, 2011-08-18 at 04:18 -0400, Luiz Augusto von Dentz wrote:
> Hi Peter,
>
> On Thu, Aug 18, 2011 at 3:37 AM, Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote:
> > Combine tx link types which use the same tx buffers. So SCO and ESCO
> > links are scheduled together and also schedule LE links with ACL
> > links *if* the controller uses shared ACL buffers for LE tx.
> >
> > This also fixes tx timeouts if the controller uses shared ACL buffers
> > for LE tx.
> >
> > Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
Thanks for all the great feedback, Luiz.
> I wonder if it wouldn't be simpler to just have another type e.g.
> sched_type in hci_conn, so when initializing the connection we already
> define which sched_type to use e.g. for LE sched_type = hdev->le_pkts
> ? LE_LINK : ACL_LINK.
I think this is a good idea - even if only to limit the number of bugs
that occur because of the split handling (eg., like the broken
le_last_tx timestamp now).
I had something similar in some follow-on work which vectorized the
relevant scheduler variables and transmitted the packets of a connection
from each connection type on every iteration through the connection
list. But I've pretty much abandoned that effort as unfruitful.
That type should have linearly increasing values though (to simplify any
future efforts which involve lookups/vectorization, for example).
Regards,
Peter Hurley
��.n��������+%������w��{.n�����{��� �^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
