Re: [PATCH 5/8] Added NULL check before dereferencing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Tue, Aug 16, 2011 at 12:49 PM, Pavel Raiskup <praiskup@xxxxxxxxxx> wrote:
---
 plugins/hciops.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/plugins/hciops.c b/plugins/hciops.c
index ecc0e86..e975eb5 100644
--- a/plugins/hciops.c
+++ b/plugins/hciops.c
@@ -593,7 +593,8 @@ static gboolean init_adapter(int index)
       } else {
               adapter = manager_find_adapter(&dev->bdaddr);
               /* FIXME: manager_find_adapter should return a new ref */
-               btd_adapter_ref(adapter);
+               if (adapter)
+                       btd_adapter_ref(adapter);

Perhaps we should either make manager_find_adapter to return a new ref
or create a function e.g. manager_get_adapter which does that for us.

actually, I don't have as good experiences (and time now) for such improvements. This patch has not removed "FIXME"! -- it was thought like null deref. prevention
patch only.

Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux