Hi Pavel, On Tue, Aug 16, 2011 at 6:51 AM, Pavel Raiskup <praiskup@xxxxxxxxxx> wrote: > There will be static overrun on c_brf_chip array when brf_chip > is greater than 7. > --- > tools/hciattach_tialt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/tools/hciattach_tialt.c b/tools/hciattach_tialt.c > index 1ba009c..fc3ed20 100644 > --- a/tools/hciattach_tialt.c > +++ b/tools/hciattach_tialt.c > @@ -234,7 +234,8 @@ int texasalt_init(int fd, int speed, struct termios *ti) > ((brf_chip > 7) ? "unknown" : > c_brf_chip[brf_chip]), Did you forget the line above? There's the same problem you fixed below. Maybe it's better to set brf_chip to 0 if it's greater than 7 here. > brf_chip); > > - sprintf(fw, "/etc/firmware/%s.bin", c_brf_chip[brf_chip]); > + sprintf(fw, "/etc/firmware/%s.bin", > + brf_chip > 7 ? "unknown" : c_brf_chip[brf_chip]); > texas_load_firmware(fd, fw); > > texas_change_speed(fd, speed); > -- Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
