Re: [PATCH 02/23] avrcp: use C99 instead of gcc extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 8, 2011 at 5:41 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Fri, Aug 5, 2011 at 9:15 PM, Lucas De Marchi
> <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>> ---
>>  audio/control.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/audio/control.c b/audio/control.c
>> index c3ef737..1ec736f 100644
>> --- a/audio/control.c
>> +++ b/audio/control.c
>> @@ -134,7 +134,7 @@ struct avrcp_spec_avc_pdu {
>>        uint8_t packet_type:2;
>>        uint8_t rsvd:6;
>>        uint16_t params_len;
>> -       uint8_t params[0];
>> +       uint8_t params[];
>>  } __attribute__ ((packed));
>>  #define AVRCP_SPECAVCPDU_HEADER_LENGTH 7
>>
>> @@ -164,7 +164,7 @@ struct avrcp_spec_avc_pdu {
>>        uint8_t rsvd:6;
>>        uint8_t packet_type:2;
>>        uint16_t params_len;
>> -       uint8_t params[0];
>> +       uint8_t params[];
>>  } __attribute__ ((packed));
>>  #define AVRCP_SPECAVCPDU_HEADER_LENGTH 7
>
> Not sure if this is really necessary, there several places where we do
> that and we normally use __attribute__((packed)) is we still depend on
> gcc extension in one way or the other.

Fair enough. I just try to use C99 whenever possible.


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux