On Thu, Aug 04, 2011, Frédéric Dalleau wrote:
> >>+ if (cond& (G_IO_ERR | G_IO_HUP)) {
> >
> >Since this function is only called for NVAL, ERR and HUP, do you even
> >need to have this check here. Maybe you could just get rid of this
> >second if-statement.
>
> To be rigorous the test is not needed. This is more a matter of
> consistency, since the code is nearly a copy paste of the existing
> sco_io_cb.
>
> If it is ok for you, I'll update both funcs.
Yes, though separate patches please.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
