Hi Padovan,
On Wed, Aug 3, 2011 at 1:58 PM, Gustavo Padovan <padovan@xxxxxxxxxxxxxx> wrote:
> Hi Briglia,
>
> * Anderson Briglia <anderson.briglia@xxxxxxxxxxxxx> [2011-08-02 14:35:03 -0400]:
>
>> This patch adds two new Management commands: Enable/Disable RSSI
>> Monitor. This command is used to handle a list of monitors in order to
>> monitor the RSSI value of a connection. It is useful on Proximity
>> profile implementation.
>>
>> Signed-off-by: Anderson Briglia <anderson.briglia@xxxxxxxxxxxxx>
>> ---
>> include/net/bluetooth/mgmt.h | 12 ++++++++++++
>> net/bluetooth/mgmt.c | 22 ++++++++++++++++++++++
>> 2 files changed, 34 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
>> index 5428fd3..ef3b636 100644
>> --- a/include/net/bluetooth/mgmt.h
>> +++ b/include/net/bluetooth/mgmt.h
>> @@ -211,6 +211,18 @@ struct mgmt_cp_unblock_device {
>> bdaddr_t bdaddr;
>> } __packed;
>>
>> +#define MGMT_OP_ENABLE_RSSI_MONITOR 0x001F
>> +struct mgmt_cp_enable_rssi_monitor {
>> + bdaddr_t bdaddr;
>> + __s8 low_alert_trigger;
>> + __s8 high_alert_trigger;
>> +} __packed;
>> +
>> +#define MGMT_OP_DISABLE_RSSI_MONITOR 0x0020
>> +struct mgmt_cp_disable_rssi_monitor {
>> + bdaddr_t bdaddr;
>> +} __packed;
>> +
>
> Make much more sense to me call this ADD/REMOVE. We add an rssi monitor to the
> list and then remove it from the list.
>
Actually it depends. From the userspace point of view, there is no
list to add or remove elements. The user/application just enable or
disable the RSSI monitoring for a connection. But, I can't see
problems in changing the commands names if you prefer.
> Gustavo
>
--
INdT - Instituto Nokia de tecnologia
+55 92 2126 1122
+55 92 8423 3183
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
