Hi Johan: For your comments, I will send the patch again after modifying git settings. Best regards Zheng wu > -----Original Message----- > From: Johan Hedberg [mailto:johan.hedberg@xxxxxxxxx] > Sent: Tuesday, July 26, 2011 5:29 PM > To: Zheng, Wu > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fixing crash in irmc.c when vcard=0 > > Hi, > > On Fri, Jul 15, 2011, zheng wu wrote: > > When using sync profile, if getting the number of vcard is 0 in > server,obexd will crash. > > The reason is that the null point is used in query_result of > irmc.c.The patch is for fixing it. > > Signed-off-by: wu.zheng@xxxxxxxxx > > --- > > plugins/irmc.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > The patch itself seems ok to me, but you need to fix your git settings: > > 1. Don't use Signed-off-by (this is only used for kernel patches). > 2. Format your commit message lines to max 72 characters > 3. Fix your git author name (first letter capitalized, etc.) > > Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html