RE: [PATCH] Fix mem leak in sap plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz
>Hi,
>
>On Fri, Jul 15, 2011 at 2:38 PM, Arek Lichwa <arkadiusz.lichwa@xxxxxxxxx>
>wrote:
>> When dropping rfcomm channel to sap server, the component's channel
>> cleanup process doesn't release assigned glib channel resources.
>> ---
>>  sap/server.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/sap/server.c b/sap/server.c
>> index c55aa6e..8bd8fe1 100644
>> --- a/sap/server.c
>> +++ b/sap/server.c
>> @@ -1122,7 +1122,6 @@ static void sap_io_destroy(void *data)
>>                                conn->state ==
>SAP_STATE_GRACEFUL_DISCONNECT)
>>                        sap_disconnect_req(NULL, 1);
>>
>> -               conn->io = NULL;
>>                sap_conn_remove(conn);
>>        }
>>  }
>> --
>> 1.7.6
>
>It doesn't seems this release any memory, maybe the problem is not a
>memory leak but an invalid access to freed memory?

Actually the realese/cleanup process of glib resource isn't triggered.
It would when last reference to conn->io get 0. It's been triggered in 
sap_conn_remove() but conn->io already got null before that.
So it needs better description ?

/Arek
>
>--
>Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux