Re: [PATCH BlueZ 08/12] Drop GAttrib ref if callback list is empty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Claudio,

On Wed, Jul 06, 2011, Claudio Takahasi wrote:
> If all ATT connection callbacks are unregistered, GAttrib reference
> can be dropped.
> ---
>  src/device.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Patches 1-7 have been applied, but this one looked strange:

> --- a/src/device.c
> +++ b/src/device.c
> @@ -2605,10 +2605,15 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
>  
>  	g_free(attio);
>  
> +	if (device->attios != NULL)
> +		return TRUE;
> +
>  	if (device->attioid) {
>  		g_source_remove(device->attioid);
>  		device->attioid = 0;
>  	}
>  
> +	g_attrib_unref(device->attrib);
> +
>  	return TRUE;
>  }

Looks like you're missing a device->attrib = NULL; after the unref.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux