Re: [PATCH obexd] Remove redundant copy of GSlist* from functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Syam,

On Sat, Jun 25, 2011, Syam Sidhardhan wrote:
> Local copy of the pointer to list is not required, because these
> functions already has a copy, through the arguments.
> ---
>  gdbus/object.c              |    6 ++----
>  plugins/phonebook-tracker.c |   23 ++++++++---------------
>  src/service.c               |    6 ++----
>  3 files changed, 12 insertions(+), 23 deletions(-)

I still prefer l/list as the iterator variable for lists (just like "i"
is intuitive as an integer iterator). Since the gain (one less stack
variable) is not significant here while the readability is somewhat made
worse, I'd rather not apply this patch.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux