Re: [PATCH] Health Thermometer Profile API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Santiago,

<snip>

> +               RegisterWatcher(object agent)
> +
> +                       Registers a watcher to monitor scanned measurements.
> +                       This agent will be notified about final temperature
> +                       measurements.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +
> +               UnregisterWatcher(object agent)
> +
> +                       Unregisters a watcher.
> +
> +                       Final and intermediate temperatures won't be notified to
> +                       this agent any more.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +                                       org.bluez.Error.NotFound
> +
> +               EnableIntermediateMeasurement(object agent)

It'd be good to try hide from the apps notifications and indications.
My opinion is: watchers doesn't need to know if the characteristic
value is a notification or indication.
The thermometer implementation could enable automatically
notifications if there is at least one watcher registered.

Is it important to know if the characteristic value is intermediate or not?

> +
> +                       Enables intermediate measurement notifications for this
> +                       agent if the thermometer supports it.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +                                       org.bluez.Error.NotSupported
> +
> +               DisableIntermediateMeasurement(object agent)
> +
> +                       Disables intermediate measurement notifications for this
> +                       agent. It will disable notifications in the thermometer
> +                       when the last agent removes the watcher for intermediate
> +                       measurements.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +                                       org.bluez.Error.NotFound
> +
> +Signals                PropertyChanged(string name, variant value)
> +
> +                       This signal indicates a changed value of the given
> +                       property.
> +
> +Properties     boolean Intermediate [readonly]
> +
> +                       True if the thermometer supports intermediate measurement
> +                       notifications.
> +
> +               uint16 Interval (optional) [readwrite]
> +
> +                       The Measurement Interval defines the time (in seconds)
> +                       between measurements. This interval is not related to
> +                       the intermediate measurements and must be defined into
> +                       a valid range. Setting it to zero means that no periodic
> +                       measurements will be taken.
> +
> +               uint16 Maximum (optional) [readonly]
> +
> +                       Defines the maximum value allowed for the interval
> +                       between periodic measurements.
> +
> +               uint16 Minimum (optional) [readonly]
> +
> +                       Defines the minimum value allowed for the interval
> +                       between periodic measurements.
> +

Intervals could be a config option. It can be extended later if
necessary, move the config option to the API(Property) is easier than
remove a property.

Regards,
Claudio
��.n��������+%������w��{.n�����{����^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux