[PATCH] avrcp: remove unused dbus reply message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fix leak of dbus messages being created but not unreferenced after
method returns.
---
 audio/control.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/audio/control.c b/audio/control.c
index defbbc8..c3ef737 100644
--- a/audio/control.c
+++ b/audio/control.c
@@ -1045,13 +1045,8 @@ static DBusMessage *volume_up(DBusConnection *conn, DBusMessage *msg,
 {
 	struct audio_device *device = data;
 	struct control *control = device->control;
-	DBusMessage *reply;
 	int err;
 
-	reply = dbus_message_new_method_return(msg);
-	if (!reply)
-		return NULL;
-
 	if (control->state != AVCTP_STATE_CONNECTED)
 		return btd_error_not_connected(msg);
 
@@ -1070,13 +1065,8 @@ static DBusMessage *volume_down(DBusConnection *conn, DBusMessage *msg,
 {
 	struct audio_device *device = data;
 	struct control *control = device->control;
-	DBusMessage *reply;
 	int err;
 
-	reply = dbus_message_new_method_return(msg);
-	if (!reply)
-		return NULL;
-
 	if (control->state != AVCTP_STATE_CONNECTED)
 		return btd_error_not_connected(msg);
 
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux