Re: [PATCH 1/2] Convert dos file to unix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 3, 2011 at 8:41 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Lucas,
>
> On Sat, Jul 02, 2011, Lucas De Marchi wrote:
>> Call `tr -d \\r < tools/ubcsp.c', and since this will change all the
>> lines, remove the trailing white spaces too.
>> ---
>>  tools/ubcsp.c | 2360 ++++++++++++++++++++++++++++----------------------------
>>  1 files changed, 1180 insertions(+), 1180 deletions(-)
>
> I'm not really sure this is worth it since it'll e.g. screw up "git
> blame" for this file. If it was a file that's likely to receive updates
> it'd be different, but since the last change to it was from 2008 I don't
> see that as likely. OTOH I don't really have such a strong opinion about
> this, so if Marcel is fine with it we can apply the patch upstream.

I didn't notice the second patch could be applied regardless of this
first one (unless you removed the part that touches this file).

This \r char was screwing up codespell output and I'm not really happy
fixing it (though I'd welcome a patch).


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux