Re: [PATCH] avrcp: mark signals as deprecated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gustavo,

On Sun, Jul 03, 2011, Gustavo F. Padovan wrote:
> > On Sat, Jul 02, 2011, Gustavo F. Padovan wrote:
> > > From: "Gustavo F. Padovan" <padovan@xxxxxxxxxxxxxx>
> > > 
> > > Connected and Disconnected are deprecated signals
> > > ---
> > >  doc/control-api.txt |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Why do you think these should be deprecated? Right now there are no
> > other signals available in the org.bluez.Control interface that'd give
> > the same information.
> 
> I'm just following the code:
> 
> static GDBusSignalTable control_signals[] = {
>         { "Connected",                  "",     G_DBUS_SIGNAL_FLAG_DEPRECATED},
>         { "Disconnected",               "",     G_DBUS_SIGNAL_FLAG_DEPRECATED},

That's probably a mistake from copy-pasting the same stuff to each audio
profile. We could of course consider adding a State property to match
the other profiles, and then these signals could really be marked as
deprecated.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux