[PATCH obexd 1/2] Return empty body instead -ENOENT when phonebook is empty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Previously, when doing pull of empty phonebook, NOT FOUND error was
returned. Now returning empty body - this change is needed to pass PTS
testcase TC_PSE_PDF_BV_05_I (this testcase is optional).

PBAP spec says, that error NOT_FOUND should be returned when phonebook object
could not be found - very strict clients may think that phonebook does not exist
(and in scenario described above phonebook exists but its content is empty).
---
 plugins/pbap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/pbap.c b/plugins/pbap.c
index 0356ae7..ab1d9ce 100644
--- a/plugins/pbap.c
+++ b/plugins/pbap.c
@@ -301,7 +301,7 @@ static void query_result(const char *buffer, size_t bufsize, int vcards,
 
 	pbap->obj->lastpart = lastpart;
 
-	if (vcards <= 0) {
+	if (vcards < 0) {
 		obex_object_set_io_flags(pbap->obj, G_IO_ERR, -ENOENT);
 		return;
 	}
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux