Re: [PATCH hcidump 1/3] Add basic AVCTP parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jun 24, 2011 at 12:24 PM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote:
> Hi Luiz,
>
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>
>> ---
>>  parser/avctp.c  |   29 +++++++++++++++++++++++++++--
>>  parser/parser.h |    1 +
>>  2 files changed, 28 insertions(+), 2 deletions(-)
>>
>> diff --git a/parser/avctp.c b/parser/avctp.c
>> index 4a8876c..aa2def1 100644
>> --- a/parser/avctp.c
>> +++ b/parser/avctp.c
>> @@ -36,10 +36,35 @@
>>
>>  #include "parser.h"
>>
>> +static char *pt2str(uint8_t hdr)
>> +{
>> +     switch (hdr & 0x0c) {
>> +     case 0x00:
>> +             return "";
>> +     case 0x04:
>> +             return "Start";
>> +     case 0x08:
>> +             return "Cont";
>> +     case 0x0c:
>> +             return "End";
>> +     default:
>> +             return "Unk";
>> +     }
>> +}
>> +
>>  void avctp_dump(int level, struct frame *frm)
>>  {
>> +     uint8_t hdr;
>> +     uint16_t pid;
>> +
>>       p_indent(level, frm);
>> -     printf("AVCTP:\n");
>>
>> -     raw_dump(level, frm);
>> +     hdr = get_u8(frm);
>> +     pid = get_u16(frm);
>> +
>> +     printf("AVCTP: %s %s: pt 0x%02x transaction %d pid 0x%04x \n",
>> +                             hdr & 0x02 ? "Response" : "Command",
>> +                             pt2str(hdr), hdr & 0x0c, hdr >> 4, pid);
>> +
>> +     raw_dump(level + 1, frm);
>>  }
>> diff --git a/parser/parser.h b/parser/parser.h
>> index bbdfc01..cf40034 100644
>> --- a/parser/parser.h
>> +++ b/parser/parser.h
>> @@ -231,6 +231,7 @@ void hidp_dump(int level, struct frame *frm);
>>  void hcrp_dump(int level, struct frame *frm);
>>  void avdtp_dump(int level, struct frame *frm);
>>  void avctp_dump(int level, struct frame *frm);
>> +void avrcp_dump(int level, struct frame *frm);
>
> Shouldn't this go to "[PATCH hcidump 2/3] Add basic AVRCP parsing" ?

Opps, gonna fix it, thanks.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux