Hi Nami, On Mon, Jun 20, 2011 at 12:44 PM, Nami <nami.li@xxxxxxxxxxx> wrote: > Hi,all > These patches support opp and ftp over l2cap. Currently I just modified OPP and FTP. > Please help review these patches. > Thanks. > > --- > plugins/opp.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/plugins/opp.c b/plugins/opp.c > index 17c4356..7ea7e18 100644 > --- a/plugins/opp.c > +++ b/plugins/opp.c > @@ -71,7 +71,7 @@ > <sequence> \ > <sequence> \ > <uuid value=\"0x1105\"/> \ > - <uint16 value=\"0x0100\" name=\"version\"/> \ > + <uint16 value=\"0x0102\" name=\"version\"/> \ > </sequence> \ > </sequence> \ > </attribute> \ > @@ -91,6 +91,10 @@ > <uint8 value=\"0xff\"/> \ > </sequence> \ > </attribute> \ > + \ > + <attribute id=\"0x0200\"> \ > + <uint16 value=\"%u\" name=\"psm\"/> \ > + </attribute> \ > </record>" > > static void *opp_connect(struct obex_session *os, int *err) > -- > 1.7.1 > > -- I review some of the more obvious issues, but you please next send the obex-client and obexd in different series? It confuses use since the sometimes are similar but for different purposes (client/server), also personally I don't suggest sending big series (> 5 patches), split them into logical sets e.g server, client, gwobex (this is actually necessary to apply to gwobex repository too) and send them separated waiting them to get applied before sending the next one. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
