Re: [PATCH obexd 10/10] Add func for fetching header by id from list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

On Sun, Jun 19, 2011 at 3:59 AM, Jakub Adamek <adamek.kuba@xxxxxxxxx> wrote:
> ---
>  gwobex/obex-xfer.c |   10 ++++++++++
>  gwobex/obex-xfer.h |    2 ++
>  2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/gwobex/obex-xfer.c b/gwobex/obex-xfer.c
> index 20a3221..413fed9 100644
> --- a/gwobex/obex-xfer.c
> +++ b/gwobex/obex-xfer.c
> @@ -472,6 +472,16 @@ void a_header_free(struct a_header *ah) {
>     g_free(ah);
>  }
>
> +struct a_header *a_header_find(GSList *aheaders, uint8_t hi) {
> +    while (aheaders) {

Avoid casts, use a proper variable e.g. struct a_header *ah =
aheaders->data and avoid braces for single line if statements.

> +        if (((struct a_header *)aheaders->data)->hi == hi) {
> +            return aheaders->data;
> +        }
> +        aheaders = g_slist_next(aheaders);
> +    }
> +    return NULL;
> +}
> +
>  void _gw_obex_xfer_free(struct gw_obex_xfer *xfer) {
>     GSList *aheaders = xfer->aheaders;
>     while (aheaders) {
> diff --git a/gwobex/obex-xfer.h b/gwobex/obex-xfer.h
> index 61aa048..50dadad 100644
> --- a/gwobex/obex-xfer.h
> +++ b/gwobex/obex-xfer.h
> @@ -95,6 +95,8 @@ void a_header_free(struct a_header *ah);
>
>  struct a_header *a_header_copy(struct a_header *ah);
>
> +struct a_header *a_header_find(GSList *aheaders, uint8_t hi);
> +
>  struct gw_obex_xfer *gw_obex_xfer_new(struct gw_obex *ctx, gboolean async, int stream_fd);
>
>  void _gw_obex_xfer_free(struct gw_obex_xfer *xfer);
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux