Re: [PATCH 3/4] Modify obex_write_stream logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinicius,

On Thu, Jun 16, 2011 at 7:51 PM, Vinicius Costa Gomes
<vinicius.gomes@xxxxxxxxxxxxx> wrote:
>> Sorry I have to disagree here, adding another callback probably
>> simplify the code a bit since we can have something like this:
>>
>> if (!streaming && driver->get_apparams)
>>     driver->get_apparams...
>>
>> So just drivers that support get_apparams will be called and that
>> should be enough to guarantee the apparams are added in the beginning
>> packet.
>>
>> Custom headers are a different matter, right now we don't have any
>> plugin/driver who need them.
>
> But we will have soon, BIP needs them. So we better start considering
> how should we export it to the plugins.

Sure, still a different plugin, maybe when BIP is to be introduced we
should actually give the OpenOBEX object to the drivers, so that each
plugin can add their own headers in whatever order they want, or have
an abstraction of the object e.g. obexd_object which the plugins can
use to add their own headers. How about that?

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux