Hi Marcel, OK, I will split my patches into small logical pieces and upload later. Thanks. Nami -----Original Message----- From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx] Sent: 2011å6æ15æ 19:15 To: Li, Nami Cc: linux-bluetooth@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/2] Bluetooth: FTP and OPP over L2CAP Hi Nami, > From: nami <nami.li@xxxxxxxxxxx> > > > Signed-off-by: Nami <nami.li@xxxxxxxxxxx> the number one thing here is to get your GIT setup done right and follow our polices like no signed-off-by line for bluez and obexd submissions. > --- > client/main.c | 26 +++++++---- > client/session.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++---- > client/session.h | 6 +++ > gwobex/gw-obex.c | 6 +- > gwobex/gw-obex.h | 3 +- > gwobex/obex-priv.c | 4 +- > gwobex/obex-priv.h | 2 +- > plugins/bluetooth.c | 112 +++++++++++++++++++++++++++++++++++++++++++++--- > plugins/ftp.c | 8 +++- > plugins/opp.c | 8 +++- > src/obex.c | 10 +++- > src/service.h | 7 +++ > test/main.c | 2 +- > 13 files changed, 275 insertions(+), 38 deletions(-) And without even looking at the actual patch, I can tell you right now here that you should have split this up into logical pieces. For example gwobex should be it separate patch in the first place. And I assume others can also be nicely split up. These "monster" patches are not acceptable. Regards Marcel ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ý¶ â^n‡r¡öë¨è&£ûz¹Þúzf£¢·hšˆ§~††Ûÿÿïÿ‘ê_èæ+v‰¨þ)ßø
