On Tue, 14 Jun 2011 15:02:39 +0100
Bastien Nocera <hadess@xxxxxxxxxx> wrote:
> On Tue, 2011-06-14 at 16:02 +0300, Johan Hedberg wrote:
> > Hi Bastien,
> > > diff --git a/src/manager.c b/src/manager.c
> > > index e805e0c..9d0de25 100644
> > > --- a/src/manager.c
> > > +++ b/src/manager.c
> > > @@ -288,6 +288,11 @@ static void manager_remove_adapter(struct btd_adapter *adapter)
> > > btd_start_exit_timer();
> > > }
> > >
> > > +int manager_get_default_adapter_id(void)
> > > +{
> > > + return default_adapter_id;
> > > +}
> >
> > Would it not make more sense to have something that returns the adapter
> > object directly? I.e. are there actually any use cases where some plugin
> > would want the id but *not* want to resolve the matching adapter object?
> > And even if the plugin still needs the id (which I'd expect to be a
> > minority use-case if it exists at all) it can always call
> > adapter_get_dev_id().
>
> I really really don't care either way. I sent both variations of the
> patch already (Antonio has one in his patchset, and I sent the other).
> Commit either, and we'll change our patches.
>
Yep, same for me, either this one or the one in
http://article.gmane.org/gmane.linux.kernel.input/19751 is OK, we just
need a way to get the default adapter, please.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
Attachment:
pgpPNIKXOr0x1.pgp
Description: PGP signature
