Hi Bastien, On Tue, Jun 14, 2011, Bastien Nocera wrote: > On Tue, 2011-06-14 at 11:07 +0300, Johan Hedberg wrote: > > Hi Bastien, > <snip> > > This could simply be: > > > > if (adapter->up) > > return adapter_ops->set_name(adapter->dev_id, name); > > > > return 0; > > > > Other than that I didn't find any major issues, however please consider > > the suggestion from Lizardo to split the patch in two parts. > > I already sent the split patches (2 of them) last week: > http://thread.gmane.org/gmane.linux.bluez.kernel/13621 No, I did notice that thread. It's not a split of this patch. For one thing it doesn't contain any adaptername plugin at all. What about the coding style issues I pointed out? I also need to look more carefully into the name_stored change. I'm not sure you completely understood its significance. This is also a change which doesn't exist in your original patch (again confirming that the new thread is *not* a split of the original patch). Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
