Hi Slawek,
On Tue, Jun 14, 2011, Slawomir Bochenski wrote:
> Change introduced by commit b0619290e4128bb583268bfbfbb66de9a30ecf7c
> prevented calling count query multiple times when getting the phone book
> in parts. However value of newmissedcalls was kept between calls to
> phonebook_pull_read() resulting in adding application parameters header
> multiple times.
> ---
> plugins/phonebook-tracker.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
> index 80dfc02..d396203 100644
> --- a/plugins/phonebook-tracker.c
> +++ b/plugins/phonebook-tracker.c
> @@ -1551,6 +1551,8 @@ int phonebook_pull_read(void *request)
> if (!data)
> return -ENOENT;
>
> + data->newmissedcalls = 0;
> +
> if (g_strcmp0(data->req_name,"/telecom/mch.vcf") == 0 &&
> data->tracker_index == 0) {
> /* new missed calls amount should be counted only once - it
Shouldn't this be added inside the first if-statement branch instead of
affecting the whole function? It seems to me that only the first branch
deals with new missed calls.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
