RE: [PATCH v3] Add support of secure pin code in mgmt code

[<Waldemar.Rymarkiewicz@xxxxxxxxx>]

Hi, 

>I think this does not make sense. Regardless of secure being 
>TRUE or FALSE, "pinlen > 0" will never influence the condition 
>check, so this is actually equivalent to "if (secure && pinlen 
>== 16)". Maybe you
>meant:

Absolutely you are right. I think, that should look like 

if (pinlen > 0 && (!secure || pinlen == 16)) {
       btd_adapter_pincode_reply(adapter, dba, pin, pinlen);
       return 0;
}


Thanks,
Waldek
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html