Hi Waldek,
On Tue, May 31, 2011, Waldemar Rymarkiewicz wrote:
> ---
> sap/server.c | 23 +++++++++++------------
> 1 files changed, 11 insertions(+), 12 deletions(-)
All four patches have been pushed upstream, but before that I fixed the
following issues with this patch:
> - bt_io_get(io, BT_IO_RFCOMM, &gerr,
> - BT_IO_OPT_SOURCE_BDADDR, &src,
> - BT_IO_OPT_DEST_BDADDR, &dst,
> - BT_IO_OPT_INVALID);
> + bt_io_get(io, BT_IO_RFCOMM, &gerr, BT_IO_OPT_SOURCE_BDADDR, &src,
> + BT_IO_OPT_DEST_BDADDR, &dst, BT_IO_OPT_INVALID);
> +
Readability trumps strict coding style adherence here, so it's fine if
each op_opt is on its own line.
> if (!g_dbus_register_interface(connection, path, SAP_SERVER_INTERFACE,
> - server_methods, server_signals, NULL,
> - server, destroy_sap_interface)) {
> + server_methods, server_signals, NULL, server,
> + destroy_sap_interface)) {
The idea is to try to have each continuation line past the opening ( of
the g_dbus_register_interface function call if possible while keeping
the lines under 80 charcters, so the existing split is fine except that
it can be indented by one more tab.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
