Re: [PATCH v3] Fix disconnect devices after enabling offline mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafal,

On Tue, May 31, 2011, Rafal Michalski wrote:
> +	guint timer_id;

Please call this off_timer.

> +		adapter->timer_id = g_timeout_add_seconds(3,
> +					switch_off_timeout, adapter);

No magic constants whenever possible so please add a OFF_TIMER define to
the beginning of the file.

Also, it seems like you're missing the timer removal in the adapter_free
function. It would be pretty bad if the timer goes off after the adapter
object has already been freed.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux