Hi Ilia,
On Sun, May 29, 2011, Ilia, Kolominsky wrote:
> AVRCP TG now return REJECTED response with error code==Invalid
> command for command with VENDOR-DEPENDED oper. code
> ( fix for PTS certification )
> ---
> audio/control.c | 35 +++++++++++++++++++++++++++++++++++
> 1 files changed, 35 insertions(+), 0 deletions(-)
The patch looks better now, but it still doesn't apply with "git am".
Could you try sending it with git send-email and see if that helps? Also
try to apply it by to your own tree with "git am" before sending so we
avoid more unnecessary feedback rounds due this (if this still doesn't
help the fault might be in your outgoing mail server in which case
you'll need to ask your system admin to fix it or use another server).
There are also a couple more (minor) things to fix in the patch. Firstly
please fix your git author name to be "Firstname Lastname", i.e. without
the comma. Secondly, the following issues in the actual patch:
> @@ -493,6 +514,7 @@ static gboolean control_cb(GIOChannel *chan, GIOCondition cond,
> unsigned char buf[1024], *operands;
> struct avctp_header *avctp;
> struct avrcp_header *avrcp;
> +
> int ret, packet_size, operand_count, sock;
Why are you adding an extra empty line here? Please don't do that.
> + } else if ( avrcp->opcode == OP_VENDORDEP ) {
There should be no space after ( and before )
> + /* reply with REJECT msg with err. code == 0x0
There's an extra space character before the end of the line. Please
remove it.
> + pdu_spec = (void *) ( buf + sizeof(struct avctp_header)
Same here (extra space before newline). Also, I think I'd prefer not to
have a space after ( and before ).
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
