Hi Andre, On Fri, May 20, 2011 at 09:10:43PM -0300, ext Andre Guedes wrote: > There is no need to check the connection's state since hci_conn_add() > has just created a new connection and its state has been set properly. > > Signed-off-by: Andre Guedes <andre.guedes@xxxxxxxxxxxxx> Yes this is useless check. Acked-by: Ville Tervo <ville.tervo@xxxxxxxxx> > --- > net/bluetooth/hci_conn.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c > index 84ad32b..b21cbb3 100644 > --- a/net/bluetooth/hci_conn.c > +++ b/net/bluetooth/hci_conn.c > @@ -457,8 +457,8 @@ struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst, __u8 > le = hci_conn_add(hdev, LE_LINK, dst, 0); > if (!le) > return ERR_PTR(-ENOMEM); > - if (le->state == BT_OPEN) > - hci_le_connect(le); > + > + hci_le_connect(le); > > hci_conn_hold(le); > > -- > 1.7.4.1 -- Ville -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
