Re: bluez patch : Modify OPUSH sdp record when use sdptool for GOEP v2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/24 Marcel Holtmann <marcel@xxxxxxxxxxxx>:
> Hi Hui,
>
>>     So you  mean you don`t wanna to change currently add_opush
>> ,add_ftp and other obex services functions code?
>> I think instead of opush2, we can add a new goep2 command commonly to
>> sdptool to update service record like below:
>>
>>  sdptool goep2 l2cappsm SERVICE
>>
>> And in cmd_goep2 function, I first get that service original sdp
>> record, then update profile version, add new GoepL2capPsm attribute ,
>> and finally update that service record.
>> How do you think about this way ? It doesn`t influnce original command
>> and fuctions. If ok, I will send out my patch.
>
> just to make one thing perfectly clear here. The sdptool should only be
> used for testing. So you can do something like:
>
>        sdptool add --psm 2 opush
>
> And only create the extra GOEP 2.0 if the --psm switch is given. However
> it is not acceptable that you break the current behavior.
>
> Regards
>
> Marcel
>
>
>
hi, Marcel

  Can you just add below line in sdp.h ?
 #define SDP_ATTR_GOEP_L2CAP_PSM		0x0200

Because bt 3.0 is mainly used for OBEX and PAN, and the upper layer
code like obexd need this attribute id to determin remote device l2cap
psm to support OBEX over L2CAP . And only obex over l2cap can use bt
high speed.  I think this define in bluez will be more suitable than
in upper layer code.
 I just want to see your aptitude on obex14...

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux