Re: [PATCH 1/2] Add conf file support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan, Marcel,

On Fri, May 20, 2011 at 9:37 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Johan,
>
>> > This should reduce the amount of options which normally don't change each
>> > time obexd is executed.
>> > ---
>> >  Makefile.am    |    2 +-
>> >  plugins/ftp.c  |    8 ++-
>> >  src/main.c     |  176 +++++++++++++++++++++++++++++++++++++++-----------------
>> >  src/obexd.conf |   19 ++++++
>> >  4 files changed, 149 insertions(+), 56 deletions(-)
>> >  create mode 100644 src/obexd.conf
>>
>> This doesn't compile with gcc 4.6:
>>
>> src/main.c: In function ‘main’:
>> src/main.c:267:12: error: variable ‘config’ set but not used [-Werror=unused-but-set-variable]
>>
>> Please fix and resend.

Gonna fix that,

> didn't we agree on not having an obexd configuration file. That stuff
> should be part of the D-Bus service autostart file.

Well you still have to specify the configuration location on service
file, so it not like bluetoothd which always loads from a specific
location. Besides the point here is to group together configurations
that a normal user should be able to customize, so the configuration
could be on user home e.g. /home/user/.obexd.conf.

-- 
Luiz Augusto von Dentz
Computer Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux