Re: [PATCH] bluetooth: Do not ignore errors returned from strict_strtol()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* David Miller <davem@xxxxxxxxxxxxx> [2011-05-19 17:37:45 -0400]:

> 
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> diff --git a/drivers/bluetooth/btmrvl_debugfs.c b/drivers/bluetooth/btmrvl_debugfs.c
> index fd6305b..8ecf4c6 100644
> --- a/drivers/bluetooth/btmrvl_debugfs.c
> +++ b/drivers/bluetooth/btmrvl_debugfs.c
> @@ -64,6 +64,8 @@ static ssize_t btmrvl_hscfgcmd_write(struct file *file,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 10, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.hscfgcmd = result;
>  
> @@ -108,6 +110,8 @@ static ssize_t btmrvl_psmode_write(struct file *file, const char __user *ubuf,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 10, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.psmode = result;
>  
> @@ -147,6 +151,8 @@ static ssize_t btmrvl_pscmd_write(struct file *file, const char __user *ubuf,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 10, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.pscmd = result;
>  
> @@ -191,6 +197,8 @@ static ssize_t btmrvl_gpiogap_write(struct file *file, const char __user *ubuf,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 16, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.gpio_gap = result;
>  
> @@ -230,6 +238,8 @@ static ssize_t btmrvl_hscmd_write(struct file *file, const char __user *ubuf,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 10, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.hscmd = result;
>  	if (priv->btmrvl_dev.hscmd) {
> @@ -272,6 +282,8 @@ static ssize_t btmrvl_hsmode_write(struct file *file, const char __user *ubuf,
>  		return -EFAULT;
>  
>  	ret = strict_strtol(buf, 10, &result);
> +	if (ret)
> +		return ret;
>  
>  	priv->btmrvl_dev.hsmode = result;

Applied, thanks Dave!

-- 
Gustavo F. Padovan
http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux