On Tue, May 10, 2011 at 05:10:32PM +0200, Par-Gunnar Hjalmdahl wrote: > This patch adds support for the ST-Ericsson CG2900 > Connectivity Combo controller (Bluetooth, FM, GPS). > > Signed-off-by: Par-Gunnar Hjalmdahl <par-gunnar.p.hjalmdahl@xxxxxxxxxxxxxx> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> {sigh} This breaks the build again, the error messages are below :( I'm about to give up here, so the next time you send this patch in, I want some kind of proof that the code will at least build properly. How you provide this is up to you. Oh, and if the next one breaks stuff again, you will owe me a lot of beer, although I think you owe me already... thanks, greg k-h CC [M] drivers/staging/cg2900/mfd/cg2900_chip.o drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: (near initialization for âcg2900_devs[0].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2941:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2941:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: (near initialization for âcg2900_devs[1].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2946:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2946:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: (near initialization for âcg2900_devs[2].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2951:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2951:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: (near initialization for âcg2900_devs[3].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2956:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2956:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: (near initialization for âcg2900_devs[4].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2961:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2961:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: (near initialization for âcg2900_devs[5].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2966:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2966:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: (near initialization for âcg2900_devs[6].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2971:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2971:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: (near initialization for âcg2900_devs[7].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2976:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2976:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: (near initialization for âcg2900_devs[8].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2981:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2981:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: (near initialization for âcg2900_devs[9].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2986:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2986:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: warning: initialization makes integer from pointer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: initializer element is not computable at load time drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: (near initialization for âcg2900_devs[10].idâ) drivers/staging/cg2900/mfd/cg2900_chip.c:2991:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:2991:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3073:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3073:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3074:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3074:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3079:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3079:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3080:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3080:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3085:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3085:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3086:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3086:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3091:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3091:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3092:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3092:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3097:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3097:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3098:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3098:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3103:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3103:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3104:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3104:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3109:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3109:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3110:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3110:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3115:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3115:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3116:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3116:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3121:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3121:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3122:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3122:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3127:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3127:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3128:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3128:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c:3133:3: error: unknown field âplatform_dataâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3133:3: warning: initialization from incompatible pointer type drivers/staging/cg2900/mfd/cg2900_chip.c:3134:3: error: unknown field âpdata_sizeâ specified in initializer drivers/staging/cg2900/mfd/cg2900_chip.c:3134:3: warning: initialization makes pointer from integer without a cast drivers/staging/cg2900/mfd/cg2900_chip.c: In function âset_plat_dataâ: drivers/staging/cg2900/mfd/cg2900_chip.c:3147:41: error: âstruct mfd_cellâ has no member named âplatform_dataâ drivers/staging/cg2900/mfd/cg2900_chip.c:3147:37: warning: initialization from incompatible pointer type make[4]: *** [drivers/staging/cg2900/mfd/cg2900_chip.o] Error 1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html