On Fri, 06 May 2011 02:14:38 +0100 Bastien Nocera <hadess@xxxxxxxxxx> wrote: > On Fri, 2011-02-25 at 11:04 +0100, Antonio Ospite wrote: > > + [AC_LANG_PROGRAM([[ > > + #include <sys/ioctl.h> > > + #include <linux/hidraw.h> > > + #if ! (defined(HIDIOCSFEATURE) && > > defined(HIDIOCGFEATURE)) > > + #error "HIDIOCSFEATURE and > > HIDIOCGFEATURE are required (linux-libc-dev >= 2.6.3x)" > > + #endif > > + ]], > > The only part of the patch I have a problem with is this one. > > I'd rather the code had: > #ifndef HIDIOCSFEATURE > #define HIDIOCSFEATURE bleh > #endif > > And gracefully handled the ioctl not being available on the running > kernel (eg. "Not handling plugged in Sixaxis joypad because the kernel > lacks HIDIOCSFEATURE support"). > Thinking twice about that, maybe I haven't fully understood what you mean. Do you want that the plugin can be enabled and _compiled_ on _older_ kernels as well? Because about compiling on _supported_ ones and then _running_ it on _older_ ones, well, the ioctl return values are already checked and they should just (gracefully?) fail on unsupported kernels. But I'll double check this scenario. If you want indeed it to be _compiled_ on older kernels and nonetheless still work on supported ones, I think we just have to copy the iotcls request defines from hidraw.h if they are not defined but I still don't know if I like that. Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpahuz86dSxN.pgp
Description: PGP signature
