Re: [PATCH] Remove btio.c compilation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, May 5, 2011 at 2:23 AM, Elvis Pfützenreuter <epx@xxxxxxxxxxx> wrote:
> On 4 May 2011, at 20:09 , Anderson Briglia wrote:
>
>> Hi Johan,
>>
>> On Wed, May 4, 2011 at 5:39 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
>>> Hi,
>>>
>>> On Mon, May 02, 2011, anderson.briglia@xxxxxxxxxxxxx wrote:
>>>> This patch fixes a compilation warning regarding btio/btio.c
>>>> compilation.
>>>> ---
>>>>  btio/btio.c |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/btio/btio.c b/btio/btio.c
>>>> index 6d71b90..8f166cc 100644
>>>> --- a/btio/btio.c
>>>> +++ b/btio/btio.c
>>>> @@ -800,7 +800,7 @@ static gboolean l2cap_get(int sock, GError **err, BtIOOption opt1,
>>>>       uint8_t dev_class[3];
>>>>       uint16_t handle;
>>>>       socklen_t len;
>>>> -     gboolean flushable;
>>>> +     gboolean flushable = TRUE;
>>>>
>>>>       len = sizeof(l2o);
>>>>       memset(&l2o, 0, len);
>>>
>>> So are we going to get an updated patch for this (with the modifications
>>> that were requested)? It's quite clearly a false positive by the
>>> compiler (i.e. a compiler bug) but I still think that we should try to
>>> keep the BlueZ tree compilable with "./bootstrap-configure && make" for
>>> all major distributions.
>>
>> Elvis is going to open a bug in Ubuntu bug system regarding this false
>> positive. I believe it is worth to wait what Ubuntu developers will
>> say.

I don't see why it would be ubuntu specific, this seems to be some
kind of regression/'feature' with gcc 4.5.

-- 
Luiz Augusto von Dentz
Computer Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux