Re: [PATCH 2/2] Remove wrong checking for legacy devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Fri, Apr 29, 2011 at 8:27 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Claudio,
>
> On Fri, Apr 29, 2011 at 1:34 AM, Claudio Takahasi
> <claudio.takahasi@xxxxxxxxxxxxx> wrote:
>> Infer that the found device is a legacy device based on the presence
>> of its name in the storage is wrong.
>> ---
>> Âsrc/event.c | Â Â2 --
>> Â1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/event.c b/src/event.c
>> index 5373e33..b873000 100644
>> --- a/src/event.c
>> +++ b/src/event.c
>> @@ -481,8 +481,6 @@ void btd_event_device_found(bdaddr_t *local, bdaddr_t *peer, uint32_t class,
>>
>> Â Â Â Âif (data)
>> Â Â Â Â Â Â Â Âlegacy = FALSE;
>> - Â Â Â else if (name == NULL)
>> - Â Â Â Â Â Â Â legacy = TRUE;
>> Â Â Â Âelse if (read_remote_features(local, peer, NULL, features) == 0) {
>> Â Â Â Â Â Â Â Âif (features[0] & 0x01)
>> Â Â Â Â Â Â Â Â Â Â Â Âlegacy = FALSE;
>> --
>
> That was some use of it, but I can't remember now, maybe some broken
> stack which has feature bits broken or we do actually infer if we ever
> connect to the device before trying to read its features from the
> storage.
>
>
> --
> Luiz Augusto von Dentz
> Computer Engineer
>

I found the commit that introduced this code, but it is still not clear to me:
989c60c0b9c96edf1fbdf80356abf05bac336673

BTW: why this information needs to be exposed through the DeviceFound() signal?
It is not used internally in the adapter.c source.

BR,
Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux